Bump version to 3.11.2 and update dependencies#347
Merged
Conversation
- increment version from 3.11.1 to 3.11.2 in gradle.properties - update configurate dependency to 4.2.0-SNAPSHOT - update inventory-framework dependency to 1.0.4 - adjust configurate module references to forked versions
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the SURF-API release version and switches selected dependencies to forked/snapshot coordinates to support updated dependency behavior, particularly around Configurate and Inventory Framework.
Changes:
- Bumped project version from
3.11.1to3.11.2. - Updated Configurate and Inventory Framework versions and coordinates to forked artifacts.
- Disabled Inventory Framework remapper initialization because the fork no longer requires it.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
gradle.properties |
Updates the project version to 3.11.2. |
gradle/libs.versions.toml |
Switches Configurate and Inventory Framework dependencies to forked coordinates and updated versions. |
surf-api-paper/surf-api-paper-server/src/main/kotlin/dev/slne/surf/api/paper/server/inventory/framework/InventoryLoader.kt |
Disables runtime remapper setup for the forked Inventory Framework dependency. |
…settings - change configurate.yaml and configurate.jackson from compileOnlyApi to api - remove configurate.yaml and configurate.jackson from paperLibrary dependencies - update relocation settings for configurate in core-convention.gradle.kts and CoreSurfPlugin.kt - update configurate version from 4.2.0-SNAPSHOT to 1.0.0 in libs.versions.toml
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d33ac0ed3e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…eConfigManager - add comment to clarify exception handling for OLD_CONFIG_SERIALIZABLE_ANNOTATION - ensure serializers are registered only when necessary
…Manager - change catch block from Exception to Throwable to handle broader error cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to configuration management and dependency handling, focusing on updating and relocating key libraries, enhancing backwards compatibility, and improving the configuration API. The most important updates include switching to forked and relocated versions of the
ConfigurateandInventory Frameworklibraries, adding backwards compatibility for older Sponge configuration annotations, and updating dependency versions and usages throughout the project.Dependency and Relocation Updates:
ConfigurateandInventory Frameworklibraries, changing their group and version references ingradle/libs.versions.toml. This ensures the project uses custom-maintained forks and avoids conflicts with upstream packages. [1] [2]org.spongepowered.configuratein both the Gradle build script and the plugin code, ensuring all usages are correctly namespaced under the project’s relocation prefix. [1] [2]Configuration Management Improvements:
OldSpongeReflectionsutility. This allows the configuration loader to recognize and process legacy annotations, ensuring older configuration classes remain compatible. [1] [2]Project Dependency Adjustments:
configurate.yamlandconfigurate.jacksonfromcompileOnlyApitoapiinsurf-api-core, and removed them from the standalone and paper server modules, reflecting their new usage patterns and ensuring correct exposure. [1] [2] [3]Other Maintenance:
gradle.propertiesto3.11.2to reflect these changes.