Skip to content

Bump version to 3.11.2 and update dependencies#347

Merged
twisti-dev merged 6 commits into
version/26.1from
chore/update-to-forked-dependencies
May 16, 2026
Merged

Bump version to 3.11.2 and update dependencies#347
twisti-dev merged 6 commits into
version/26.1from
chore/update-to-forked-dependencies

Conversation

@twisti-dev
Copy link
Copy Markdown
Contributor

@twisti-dev twisti-dev commented May 14, 2026

This pull request introduces significant changes to configuration management and dependency handling, focusing on updating and relocating key libraries, enhancing backwards compatibility, and improving the configuration API. The most important updates include switching to forked and relocated versions of the Configurate and Inventory Framework libraries, adding backwards compatibility for older Sponge configuration annotations, and updating dependency versions and usages throughout the project.

Dependency and Relocation Updates:

  • Updated dependencies to use forked and relocated versions of Configurate and Inventory Framework libraries, changing their group and version references in gradle/libs.versions.toml. This ensures the project uses custom-maintained forks and avoids conflicts with upstream packages. [1] [2]
  • Added relocation rules for org.spongepowered.configurate in both the Gradle build script and the plugin code, ensuring all usages are correctly namespaced under the project’s relocation prefix. [1] [2]

Configuration Management Improvements:

  • Implemented backwards compatibility for pre-relocation Sponge configuration annotations by introducing the OldSpongeReflections utility. This allows the configuration loader to recognize and process legacy annotations, ensuring older configuration classes remain compatible. [1] [2]
  • Updated the configuration loader to enable YAML comments and support legacy annotation processing, improving the developer experience and migration path for existing configs. [1] [2]

Project Dependency Adjustments:

  • Changed the dependency scope for configurate.yaml and configurate.jackson from compileOnlyApi to api in surf-api-core, and removed them from the standalone and paper server modules, reflecting their new usage patterns and ensuring correct exposure. [1] [2] [3]
  • Updated the test plugin and configuration classes to demonstrate usage of both modern and legacy configuration features, including annotation-based comments. [1] [2] [3]

Other Maintenance:

  • Disabled unnecessary remapping logic in the inventory framework loader due to the adoption of the forked version, simplifying initialization.
  • Bumped the project version in gradle.properties to 3.11.2 to reflect these changes.

- increment version from 3.11.1 to 3.11.2 in gradle.properties
- update configurate dependency to 4.2.0-SNAPSHOT
- update inventory-framework dependency to 1.0.4
- adjust configurate module references to forked versions
@twisti-dev twisti-dev self-assigned this May 14, 2026
Copilot AI review requested due to automatic review settings May 14, 2026 23:31
@twisti-dev twisti-dev marked this pull request as draft May 14, 2026 23:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the SURF-API release version and switches selected dependencies to forked/snapshot coordinates to support updated dependency behavior, particularly around Configurate and Inventory Framework.

Changes:

  • Bumped project version from 3.11.1 to 3.11.2.
  • Updated Configurate and Inventory Framework versions and coordinates to forked artifacts.
  • Disabled Inventory Framework remapper initialization because the fork no longer requires it.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
gradle.properties Updates the project version to 3.11.2.
gradle/libs.versions.toml Switches Configurate and Inventory Framework dependencies to forked coordinates and updated versions.
surf-api-paper/surf-api-paper-server/src/main/kotlin/dev/slne/surf/api/paper/server/inventory/framework/InventoryLoader.kt Disables runtime remapper setup for the forked Inventory Framework dependency.

…settings

- change configurate.yaml and configurate.jackson from compileOnlyApi to api
- remove configurate.yaml and configurate.jackson from paperLibrary dependencies
- update relocation settings for configurate in core-convention.gradle.kts and CoreSurfPlugin.kt
- update configurate version from 4.2.0-SNAPSHOT to 1.0.0 in libs.versions.toml
@twisti-dev twisti-dev requested a review from Copilot May 16, 2026 11:10
@twisti-dev twisti-dev marked this pull request as ready for review May 16, 2026 11:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Comment thread gradle/libs.versions.toml
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d33ac0ed3e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

…eConfigManager

- add comment to clarify exception handling for OLD_CONFIG_SERIALIZABLE_ANNOTATION
- ensure serializers are registered only when necessary
…Manager

- change catch block from Exception to Throwable to handle broader error cases
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

@twisti-dev twisti-dev merged commit 23955b6 into version/26.1 May 16, 2026
3 of 7 checks passed
@twisti-dev twisti-dev deleted the chore/update-to-forked-dependencies branch May 16, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants