Feat/implement clientbound disconnect packet#84
Merged
twisti-dev merged 2 commits intoApr 13, 2025
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (3)
- .idea/vcs.xml: Language not supported
- gradle.properties: Language not supported
- surf-api-bukkit/surf-api-bukkit-api/api/surf-api-bukkit-api.api: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the
surf-api-bukkitproject, including the addition of a newDisconnectPacketinterface and its implementation, as well as updates to the packet registry to support this new packet type. Additionally, there are updates to the project configuration and versioning.New feature additions and updates:
surf-api-bukkit/surf-api-bukkit-api/api/surf-api-bukkit-api.api: Added a newDisconnectPacketinterface to handle client-bound disconnect packets.surf-api-bukkit/surf-api-bukkit-api/src/main/kotlin/dev/slne/surf/surfapi/bukkit/api/nms/listener/packets/clientbound/DisconnectPacket.kt: Implemented theDisconnectPacketinterface with areasonproperty.Packet registry updates:
surf-api-bukkit/surf-api-bukkit-server/src/main/kotlin/dev/slne/surf/surfapi/bukkit/server/impl/nms/listener/packets/PacketRegistry.kt: Updated the packet registry to include the newClientboundDisconnectPacketand its implementation. [1] [2] [3]surf-api-bukkit/surf-api-bukkit-server/src/main/kotlin/dev/slne/surf/surfapi/bukkit/server/impl/nms/listener/packets/clientbound/ClientboundDisconnectPacketImpl.kt: Added the implementation for theClientboundDisconnectPacketImplclass.surf-api-bukkit/surf-api-bukkit-server/src/main/kotlin/dev/slne/surf/surfapi/bukkit/server/impl/nms/listener/packets/clientbound/NmsClientboundPacketImpl.kt: Created an abstract classNmsClientboundPacketImplto serve as a base for client-bound packet implementations.Configuration and version updates:
.idea/vcs.xml: Added commit message inspection profiles to enforce commit message format and naming conventions.gradle.properties: Updated the project version to1.21.4-2.13.0-SNAPSHOT.