Skip to content

Add self-emitter option to playSound function#96

Merged
ammodev merged 4 commits into
version/1.21from
feat/add-emitter-to-playsound
May 19, 2025
Merged

Add self-emitter option to playSound function#96
ammodev merged 4 commits into
version/1.21from
feat/add-emitter-to-playsound

Conversation

@ammodev
Copy link
Copy Markdown
Member

@ammodev ammodev commented May 19, 2025

No description provided.

Copilot AI review requested due to automatic review settings May 19, 2025 16:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces an overloaded playSound function with a self-emitter option to allow sounds to be played with a self-targeted emitter, providing additional flexibility when invoking the API.

  • Added a new overload for playSound accepting a Boolean for self-emitter selection.
  • Updated API interface definitions in multiple modules accordingly.
  • Bumped the version in gradle.properties.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
surf-api-velocity/surf-api-velocity-api/api/surf-api-velocity-api.api Added playSound overload with a Boolean parameter to support the self-emitter option.
surf-api-core/surf-api-core-api/src/main/kotlin/dev/slne/surf/surfapi/core/api/messages/adventure/audience-extension.kt Added an inline extension function for playSound enabling self-emitter behavior.
surf-api-core/surf-api-core-api/api/surf-api-core-api.api Corresponding API signature update for the new playSound overload.
surf-api-bukkit/surf-api-bukkit-api/api/surf-api-bukkit-api.api Updated API definition to include the new playSound overload.
gradle.properties Updated SNAPSHOT version information.
Comments suppressed due to low confidence (1)

surf-api-core/surf-api-core-api/src/main/kotlin/dev/slne/surf/surfapi/core/api/messages/adventure/audience-extension.kt:25

  • [nitpick] Consider renaming the 'self' parameter to something more descriptive (e.g., 'useSelfEmitter') to improve clarity on its purpose.
inline fun Audience.playSound(self: Boolean, block: @SoundDsl Sound.Builder.() -> Unit) {

@ammodev ammodev added this pull request to the merge queue May 19, 2025
Merged via the queue into version/1.21 with commit c1a0962 May 19, 2025
4 checks passed
@ammodev ammodev deleted the feat/add-emitter-to-playsound branch October 21, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants