This repository was archived by the owner on Dec 10, 2025. It is now read-only.
Draft: 21 add more offlineplayerproperties #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
surf-cloud-core/surf-cloud-core-common/src/main/kotlin/dev/slne/surf/cloud/core/common/player/playtime/PlaytimeImpl.kt:130
- In the averagePlaytimePerServer function, calculating the average playtime and directly converting it to seconds may yield a NaN Duration if the entries collection is empty. Consider checking for empty groups or NaN values and defaulting to Duration.ZERO.
.average().seconds
surf-cloud-core/surf-cloud-core-common/src/main/kotlin/dev/slne/surf/cloud/core/common/player/playtime/PlaytimeImpl.kt:139
- Similarly, in the averagePlaytimePerServer branch with the 'since' filter, the use of .average().seconds can lead to a NaN Duration when there are no matching entries. Consider handling the empty case explicitly.
.average().seconds
…ts in PlaytimeImpl
…onents, BitSet, and UUID
…disconnect handling
Contributor
There was a problem hiding this comment.
Copilot reviewed 51 out of 51 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
surf-cloud-api/surf-cloud-api-common/src/main/kotlin/dev/slne/surf/cloud/api/common/netty/packet/packet-extension.kt:72
- [nitpick] Consider specifying an explicit type argument for the serializer() call for clarity and to prevent potential ambiguity in type inference.
val serializer = serializer()
README.md:7
- [nitpick] Verify if the added external link is intentional; if not, consider removing it to keep the README focused on project-related resources.
https://chatgpt.com/g/g-67f7a61dc2208191bea4663d0771d6dd-flyway-migration-generator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be a draft, but we don't have the GitHub Team plan anymore.
Closes #21