feat: update event handling for player connection to use ServerConnec…#34
Merged
TheBjoRedCraft merged 2 commits intoversion/1.21.11from Feb 22, 2026
Merged
Conversation
twisti-dev
approved these changes
Feb 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the event handling for player server connections in the Velocity proxy plugin, migrating from ServerPreConnectEvent to ServerConnectedEvent. This change improves the timing and reliability of server switch tracking by listening to post-connection events rather than pre-connection events.
Changes:
- Replaced
ServerPreConnectEventwithServerConnectedEventfor tracking player server switches - Updated event parameter access to match the new event API (using
event.serverandevent.previousServeras Optional) - Removed event priority annotation as it's no longer needed for post-connection events
- Bumped version to 1.21.11-1.2.5-SNAPSHOT
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/listener/ConnectionListener.kt | Updated onConnected method to use ServerConnectedEvent instead of ServerPreConnectEvent, adjusted parameter access patterns, and removed event priority |
| gradle.properties | Bumped version from 1.21.11-1.2.4-SNAPSHOT to 1.21.11-1.2.5-SNAPSHOT |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tedEvent