feat: rename PlayerClientLoadedListener to PlayerConnectListener and …

[TheBjoRedCraft]

…add player connection handling

[Copilot]

Pull request overview

Renames the Paper listener responsible for handling post-world-load player messaging and adds early connection validation to kick/disallow players whose SurfPlayer data isn’t available.

Changes:

• Renamed PlayerClientLoadedListener to PlayerConnectListener.
• Added AsyncPlayerPreLoginEvent handling to disallow logins when SurfPlayer lookup fails.
• Added a shared disconnect component builder used for both kick/disallow paths.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/listener/PlayerConnectListener.kt	Renames listener object and adds pre-login disallow + standardized disconnect message.
surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/PaperMain.kt	Updates listener registration to use the new listener name.

Comments suppressed due to low confidence (4)

surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/listener/PlayerConnectListener.kt:59

• AsyncPlayerPreLoginEvent disallows login based on surfPlayerService.findPlayerByUuid(...) being present in the cache. On Velocity, the player is cached in ConnectionListener.onLogin via a coroutine (launch { handleConnect(...) }), so the cache update can lag behind the backend connection attempt and cause legitimate players to be kicked intermittently. Consider waiting/loading the player during pre-login (e.g., call a suspending load with a short timeout from this async event), or move this validation to a later stage where the proxy cache is guaranteed to be populated.
  surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/listener/PlayerConnectListener.kt:23
• The kick is initiated by the plugin, but the cause is set to UNKNOWN. Use the most specific PlayerKickEvent.Cause available for plugin-driven kicks (typically PLUGIN) so logs/analytics and other plugins can correctly interpret the reason.
  surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/listener/PlayerConnectListener.kt:76
• Typo in the disconnect message: in German this should be capitalized as the noun "Laden" ("Beim Laden deiner Daten …").
  surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/listener/PlayerConnectListener.kt:63
• buildDisconnectComponent() rebuilds the same immutable component for every kick/disallow. Consider caching it as a private val to reduce allocations, especially since it can be executed for every connection attempt.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.