Feat/add player hider toggler by TheBjoRedCraft · Pull Request #21 · SLNE-Development/surf-event

TheBjoRedCraft · 2026-02-10T08:08:24Z

No description provided.

…improved menu options

…estions and error messages

…in player menus

…ctionality

…ment to use simple names

Copilot

Pull request overview

Adds a per-player “player visibility” setting (GUI + commands) backed by surf-settings, and restructures event-server commands/permissions while introducing a config toggle to enable/disable the feature.

Changes:

Add player visibility states, persistence hook, join handling, and a GUI/command interface to change visibility.
Replace /changeeventserverstate with /eventserver changestate and add /eventserver reload, including new permission nodes.
Extend event server config with playerVisibilityEnabled and add soft dependency wiring for surf-settings-paper.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
surf-event-base/surf-event-base-paper/src/main/kotlin/dev/slne/surf/event/base/paper/settings/menu/gui-util.kt	Adds InventoryFramework GUI helpers (outline, close button, click sound, click-cancel).
surf-event-base/surf-event-base-paper/src/main/kotlin/dev/slne/surf/event/base/paper/settings/menu/PlayerVisibilityMenu.kt	New chest GUI to select a visibility state and persist on close.
surf-event-base/surf-event-base-paper/src/main/kotlin/dev/slne/surf/event/base/paper/settings/listener/PlayerConnectionListener.kt	Applies visibility logic on player join.
surf-event-base/surf-event-base-paper/src/main/kotlin/dev/slne/surf/event/base/paper/settings/command/argument/PlayerVisibilityArgument.kt	Adds CommandAPI argument parsing + suggestions for visibility state.
surf-event-base/surf-event-base-paper/src/main/kotlin/dev/slne/surf/event/base/paper/settings/command/PlayerVisibilityCommand.kt	Adds `/playervisibility` command with GUI, info, and state subcommand.
surf-event-base/surf-event-base-paper/src/main/kotlin/dev/slne/surf/event/base/paper/settings/SettingsHook.kt	Integrates surf-settings for creating/saving/loading the player visibility setting.
surf-event-base/surf-event-base-paper/src/main/kotlin/dev/slne/surf/event/base/paper/settings/PlayerVisibilityState.kt	Introduces the visibility enum (ALL/VIP/FRIENDS/NONE).
surf-event-base/surf-event-base-paper/src/main/kotlin/dev/slne/surf/event/base/paper/settings/PlayerVisibilityService.kt	Implements hide/show logic and join-state handling, including VIP permission filtering.
surf-event-base/surf-event-base-paper/src/main/kotlin/dev/slne/surf/event/base/paper/permission/PermissionRegistry.kt	Adds new command and visibility permissions; renames event-server permission nodes.
surf-event-base/surf-event-base-paper/src/main/kotlin/dev/slne/surf/event/base/paper/config/EventServerConfig.kt	Adds `playerVisibilityEnabled` feature toggle.
surf-event-base/surf-event-base-paper/src/main/kotlin/dev/slne/surf/event/base/paper/command/EventServerStateChangeCommand.kt	Removes legacy standalone state-change command.
surf-event-base/surf-event-base-paper/src/main/kotlin/dev/slne/surf/event/base/paper/command/EventServerCommand.kt	Adds new `/eventserver` command with `changestate` + `reload`.
surf-event-base/surf-event-base-paper/src/main/kotlin/dev/slne/surf/event/base/paper/PaperMain.kt	Registers new commands/listener and initializes settings integration on enable.
surf-event-base/surf-event-base-paper/build.gradle.kts	Adds soft dependency for `surf-settings-paper` and new dependencies.
gradle.properties	Bumps project version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-18T14:01:57Z

...urf-event-base-paper/src/main/kotlin/dev/slne/surf/event/base/paper/settings/SettingsHook.kt

+
+    fun getSelectedState(playerUuid: UUID) =
+        surfSettingsApi.getPlayerSetting(playerUuid, "player-visibility")
+            ?.let { PlayerVisibilityState.valueOf(it.settingValue) }


PlayerVisibilityState.valueOf(it.settingValue) will throw an IllegalArgumentException if the stored value is missing/invalid (e.g., manual edits, old enum name). This can crash callers. Prefer a safe parse (e.g., runCatching { valueOf(...) }.getOrDefault(ALL) or a firstOrNull over entries) and fall back to ALL.

Suggested change

?.let { PlayerVisibilityState.valueOf(it.settingValue) }

?.let {

runCatching { PlayerVisibilityState.valueOf(it.settingValue) }

.getOrElse { PlayerVisibilityState.ALL }

}

Copilot · 2026-02-18T14:01:57Z

...event-base/surf-event-base-paper/src/main/kotlin/dev/slne/surf/event/base/paper/PaperMain.kt

+        if (hasSettingsHook()) {
+            runBlocking {
+                settingsHook.createSettings()
+            }
+        }


runBlocking in onEnable() can block the server startup thread while createSettings() runs (likely doing I/O). Since you already use coroutines (SuspendingJavaPlugin / plugin.launch), prefer launching a coroutine instead of blocking, or move this work to an async enable hook if available.

Copilot · 2026-02-18T14:01:58Z

...rf-event-base-paper/src/main/kotlin/dev/slne/surf/event/base/paper/settings/menu/gui-util.kt

+    }
+}
+
+fun ChestGui.withOutClicks() = apply {


Function name withOutClicks() is unclear/awkward (reads like “with out clicks”). Consider renaming to something like withoutClicks(), disableClicks(), or cancelAllClicks() for readability.

Suggested change

fun ChestGui.withOutClicks() = apply {

fun ChestGui.withoutClicks() = apply {

Copilot · 2026-02-18T14:01:58Z

...e-paper/src/main/kotlin/dev/slne/surf/event/base/paper/settings/menu/PlayerVisibilityMenu.kt

+    override fun update() {
+        pane.addItem(GuiItem(buildItem(Material.GREEN_DYE) {
+            displayName {
+                note("Alle Spieler anzeigen")
+


update() mutates pane by adding items every time it runs, but nothing clears/overwrites the previous contents. This can lead to duplicated items/handlers or stale state depending on InventoryFramework internals. Consider building the pane once (or calling a clear/remove API on the pane) before re-adding items, and only updating item meta when selectedState changes.

Copilot · 2026-02-18T14:01:58Z

...e-paper/src/main/kotlin/dev/slne/surf/event/base/paper/settings/menu/PlayerVisibilityMenu.kt

+
+        addPane(pane)
+
+        super.update()
+    }


addPane(pane) is called inside update(), so each update() call will register the same pane again. This can cause the GUI to render the pane multiple times and may duplicate click handling. Add the pane once during init and let update() only modify pane contents, then call super.update().

Copilot · 2026-02-18T14:01:59Z

...e-paper/src/main/kotlin/dev/slne/surf/event/base/paper/settings/menu/PlayerVisibilityMenu.kt

+                    playerVisibilityService.refreshState(
+                        player as? Player
+                            ?: error("Only players can have a player visibility state.")
+                    )


The menu API accepts HumanEntity, but on close it hard-fails for non-Player via error(...). To avoid a runtime crash path, make the menu/show function take Player (or handle non-player entities gracefully) and remove the cast + error call.

Copilot · 2026-02-18T14:01:59Z

...e-paper/src/main/kotlin/dev/slne/surf/event/base/paper/settings/menu/PlayerVisibilityMenu.kt

+//            selectedState = PlayerVisibilityState.FRIENDS
+//            it.whoClicked.playClickSound()
+//            it.whoClicked.sendText {
+//                appendSuccessPrefix()
+//                success("Du siehst jetzt nur Freunde.")
+//            }
+//            update()
+


There is a block of commented-out logic in the FRIENDS click handler. Leaving dead code in production makes it harder to maintain and review behavior changes later. Please remove the commented code (or gate it behind a feature flag/config if it’s intended to return soon).

Suggested change

// selectedState = PlayerVisibilityState.FRIENDS

// it.whoClicked.playClickSound()

// it.whoClicked.sendText {

// appendSuccessPrefix()

// success("Du siehst jetzt nur Freunde.")

// }

// update()

Copilot · 2026-02-18T14:01:59Z

...ase-paper/src/main/kotlin/dev/slne/surf/event/base/paper/settings/PlayerVisibilityService.kt

+
+                PlayerVisibilityState.FRIENDS -> showPlayer(it, player)
+            }
+        }


handleJoin only applies other players’ visibility settings to the joining player (i.e., whether others can see the joiner). It does not apply the joiner’s own selected visibility state to what they see, so a player with NONE/VIP will still see everyone after reconnect until they change state again. Consider calling refreshState(player) during join handling (after the loop).

Suggested change

}

}

refreshState(player)

TheBjoRedCraft added 7 commits February 9, 2026 15:34

feat: add player visibility settings and commands with GUI integration

0dc1a71

feat: enhance player visibility settings with additional aliases and …

71e415d

…improved menu options

feat: update player visibility argument to use display names for sugg…

5b92f4c

…estions and error messages

chore: bump version to 1.21.11-1.0.1-SNAPSHOT

28422a9

feat: disable 'Friends' visibility option and provide error feedback …

84222bb

…in player menus

feat: implement event server command with state change and reload fun…

9c3811b

…ctionality

feat: add VIP visibility permission and update player visibility argu…

8a9dd00

…ment to use simple names

TheBjoRedCraft self-assigned this Feb 10, 2026

TheBjoRedCraft marked this pull request as ready for review February 18, 2026 13:56

Copilot AI review requested due to automatic review settings February 18, 2026 13:56

TheBjoRedCraft enabled auto-merge February 18, 2026 13:56

Copilot started reviewing on behalf of TheBjoRedCraft February 18, 2026 13:57 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

github-merge-queue bot closed this pull request by merging all changes into version/1.21.11 in 05613b9 Feb 18, 2026

TheBjoRedCraft deleted the feat/add-player-hider-toggler branch February 18, 2026 17:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/add player hider toggler#21

Feat/add player hider toggler#21
7 commits merged intoversion/1.21.11from
feat/add-player-hider-toggler

TheBjoRedCraft commented Feb 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 18, 2026

Uh oh!

Copilot AI Feb 18, 2026

Uh oh!

Copilot AI Feb 18, 2026

Uh oh!

Copilot AI Feb 18, 2026

Uh oh!

Copilot AI Feb 18, 2026

Uh oh!

Copilot AI Feb 18, 2026

Uh oh!

Copilot AI Feb 18, 2026

Uh oh!

Copilot AI Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-            ?.let { PlayerVisibilityState.valueOf(it.settingValue) }
+            ?.let {
+                runCatching { PlayerVisibilityState.valueOf(it.settingValue) }
+                    .getOrElse { PlayerVisibilityState.ALL }
+            }

	fun ChestGui.withOutClicks() = apply {
	fun ChestGui.withoutClicks() = apply {

-        }
+        }
+        refreshState(player)

Conversation

TheBjoRedCraft commented Feb 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants