Compact binary storage for DirtyMarker & AwaitingProtectionModeConfig; fix inventory slot order#10
Merged
TheBjoRedCraft merged 2 commits intofeat/additions-for-kevinfrom Mar 12, 2026
Conversation
…s; fix inventory arrangement Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Optimize storage of items and block data in config
Compact binary storage for DirtyMarker & AwaitingProtectionModeConfig; fix inventory slot order
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sponge Configurate serialises
ByteArrayas a YAML sequence of integers (one entry per byte), making a single player inventory balloon to thousands of lines. Additionally,filterNotNull()on the inventory array before serialisation stripped empty slots, restoring items to wrong positions after a server restart.Storage format
DirtyMarkerandAwaitingProtectionModeConfignow each hold a singledata: String— a Base64-encoded binary blob — instead of multiple typed YAML fields.Before:
After:
Both classes expose typed property getters (
playerUuid,inventory,startLocation,location,blockData) that decode on demand, and staticcreate(...)factory methods for construction.Inventory slot order fix
Serialisation now uses Paper's
ItemStack.serializeItemsAsBytes(*items)with nulls mapped toItemStack.empty(), preserving all 41 slot indices. The oldfilterNotNull()call collapsed the sparse array into a dense one, causing items to land in wrong slots on restoration.Removed
Location.asString()extensionList<ItemStack>.serializeItemsToBytes()extensionString.toLocation()extensionAll three were only used by the old constructors.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
downloads.gradle.org/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -Xmx64m -Xms64m -Dorg.gradle.appname=gradlew -jar /home/REDACTED/work/surf-protect/surf-protect/gradle/wrapper/gradle-wrapper.jar tasks(dns block)/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -Xmx64m -Xms64m -Dorg.gradle.appname=gradlew -jar /home/REDACTED/work/surf-protect/surf-protect/gradle/wrapper/gradle-wrapper.jar --help(dns block)/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -Xmx64m -Xms64m -Dorg.gradle.appname=gradlew -jar /home/REDACTED/work/surf-protect/surf-protect/gradle/wrapper/gradle-wrapper.jar build --parallel(dns block)repo.slne.dev/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -XX:MaxMetaspaceSize=384m -XX:+HeapDumpOnOutOfMemoryError -Xms256m -Xmx512m -Dfile.encoding=UTF-8(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.