refactor: replace appendPrefix with more specific prefixes for mess…#4
Merged
Keviro merged 1 commit intoversion/1.21.11from Jan 22, 2026
Merged
refactor: replace appendPrefix with more specific prefixes for mess…#4Keviro merged 1 commit intoversion/1.21.11from
appendPrefix with more specific prefixes for mess…#4Keviro merged 1 commit intoversion/1.21.11from
Conversation
…aging output across menus and commands - Update `appendPrefix` calls to `appendSuccessPrefix`, `appendErrorPrefix`, and `appendInfoPrefix` for clearer context in user feedback. - Increment project version to `1.21.11-2.0.1-SNAPSHOT`.
There was a problem hiding this comment.
Pull request overview
This PR refactors messaging output across the settings plugin by replacing the generic appendPrefix() method with more specific prefix methods (appendSuccessPrefix(), appendErrorPrefix(), and appendInfoPrefix()), providing clearer semantic context for different types of user feedback. The version is incremented to 1.21.11-2.0.1-SNAPSHOT.
Changes:
- Replace generic
appendPrefix()with context-specific prefix methods in menu files - Update command argument error messages to use
appendErrorPrefix() - Apply appropriate prefixes (success/error/info) in command implementations
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| LobbySettingsMenu.kt | Updated 2 toggle success messages to use appendSuccessPrefix() |
| FriendSettingsMenu.kt | Updated 4 toggle success messages to use appendSuccessPrefix() |
| ClanSettingsMenu.kt | Updated 4 toggle success messages to use appendSuccessPrefix() |
| ChatSettingsMenu.kt | Updated 4 toggle success messages to use appendSuccessPrefix() |
| SettingArgument.kt | Updated argument validation error to use appendErrorPrefix() |
| NiceToggleArgument.kt | Updated argument validation error to use appendErrorPrefix() |
| SurfSettingsCommand.kt | Updated refresh success, empty list error, and list info messages with appropriate prefixes |
| SettingsCommand.kt | Updated Folia error, validation errors, success messages, and info query with appropriate prefixes |
| gradle.properties | Incremented version from 1.21.11-2.0.0-SNAPSHOT to 1.21.11-2.0.1-SNAPSHOT |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…aging output across menus and commands
appendPrefixcalls toappendSuccessPrefix,appendErrorPrefix, andappendInfoPrefixfor clearer context in user feedback.1.21.11-2.0.1-SNAPSHOT.