Conversation
Codecov Report
@@ Coverage Diff @@
## devel #67 +/- ##
=======================================
Coverage 16.02% 16.02%
=======================================
Files 26 26
Lines 2503 2503
=======================================
Hits 401 401
Misses 2102 2102
Continue to review full report at Codecov.
|
Member
Author
|
All tests pass but I also made a UML class diagram to catch any changes to the runner scripts since we don't have good test coverage. Merging into devel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very basic refactor of photometry.py, still needs more work.
Adds some abstractions for:
Will need changes to tests
Future work: refactor to separate out the steps so that flows photometry is a nice ETL pipeline, but the ingest is an ELT pipeline. AInstead of working with raw tables as output work with stateful classes (or the database) so that plotting can be separated away from the calculation, and either autophot or alternative phot methods, can be plugged in. Also so that outputs can be easily used in a calibration (e.g., color-terms) module.