fix: resolve wallet accessibility and mobile navbar issues (#28, #29)#92
Merged
IbrahimIjai merged 10 commits intoMay 27, 2026
Conversation
Improve screen-reader support on connect and account controls by adding labels and menu semantics. Co-authored-by: Cursor <cursoragent@cursor.com>
Open connect flow in an accessible dialog with Escape-to-close and Tab focus containment to prevent focus escape. Co-authored-by: Cursor <cursoragent@cursor.com>
Support ArrowUp/ArrowDown, Enter, and Escape interactions so the account menu is keyboard-operable. Co-authored-by: Cursor <cursoragent@cursor.com>
Move focus into the menu on open and return it to the trigger on close for predictable keyboard flow. Co-authored-by: Cursor <cursoragent@cursor.com>
Expose connecting feedback through ARIA status semantics while keeping spinner decorative for assistive tech. Co-authored-by: Cursor <cursoragent@cursor.com>
Use a shorter wallet badge label to prevent navbar crowding on narrow mobile viewports. Co-authored-by: Cursor <cursoragent@cursor.com>
Render shorter mobile labels for connect and account states to keep controls usable on small screens. Co-authored-by: Cursor <cursoragent@cursor.com>
Anchor the wallet menu to the viewport bottom on mobile to prevent clipping and off-screen dropdown content. Co-authored-by: Cursor <cursoragent@cursor.com>
Reduce action spacing and enforce shrink behavior so navbar controls fit iPhone-width viewports. Co-authored-by: Cursor <cursoragent@cursor.com>
Apply mobile width and nowrap constraints so wallet controls stay inside the navbar without horizontal scrolling. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@collinsadi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
TheCodingChef-eth
added a commit
to TheCodingChef-eth/interface
that referenced
this pull request
May 29, 2026
fix: resolve all four issues: SO4-Markets#128 SO4-Markets#92 — Replace claimRewards stub wi…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Closes #28
Closes #29
Made with Cursor