Skip to content

additional fix for the Oracle test#680

Closed
comorekf wants to merge 1 commit intoSOCI:masterfrom
comorekf:fix-catch-polymorphic-by-value-oracle
Closed

additional fix for the Oracle test#680
comorekf wants to merge 1 commit intoSOCI:masterfrom
comorekf:fix-catch-polymorphic-by-value-oracle

Conversation

@comorekf
Copy link
Contributor

Added the missing fix for Oracle db. The same idea as the original fix for gcc 8.1 compiler.

vadz pushed a commit to vadz/soci that referenced this pull request Sep 17, 2018
This is similar to fcd1eec which didn't
cover the Oracle-specific tests.

Closes SOCI#680
@vadz
Copy link
Member

vadz commented Sep 17, 2018

Applied, thanks!

@vadz vadz closed this Sep 17, 2018
@vadz
Copy link
Member

vadz commented Sep 20, 2018

Oops, I've just realized that I had only pushed this to my fork and not to SOCI itself. Corrected now, sorry for the delay.

@mloskot mloskot added this to the 4.0.0 milestone Sep 20, 2018
@mloskot
Copy link
Contributor

mloskot commented Sep 20, 2018

Thanks!

@vadz
Copy link
Member

vadz commented Sep 20, 2018

Unfortunately Oracle CI build seems to be consistently broken now. As usual, I have no idea about how to fix it :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants