Fixes false positives in case of identifier with bind mark (:)#782
Closed
rommelst wants to merge 2 commits intoSOCI:masterfrom
rommelst:master
Closed
Fixes false positives in case of identifier with bind mark (:)#782rommelst wants to merge 2 commits intoSOCI:masterfrom rommelst:master
rommelst wants to merge 2 commits intoSOCI:masterfrom
rommelst:master
Conversation
vadz
reviewed
Jan 27, 2020
Member
vadz
left a comment
vadz
left a comment
There was a problem hiding this comment.
Thanks for the update!
It's fine to merge, IMO, but I'd like to get rid of exception-eating catch(...){} constructs -- unless they're really needed for some reason?
Member
|
Thanks again and sorry for the delay with merging this, but it's finally done now! |
ckroehnert
added a commit
to ckroehnert/soci
that referenced
this pull request
Dec 3, 2020
* is broken with issue SOCI#782
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changed for postgresql_statement_backend::prepare to not consider : as bind variable mark when inside postgresql identifier.