Fix bind const std::vector<boost::optional<>> with soci::use;

[Lokimed]

No description provided.

[Lokimed]

i will fix test. boost need test in common-tests.h

[vadz]

This isn't really specific to vectors of boost::optional, is it?

I'm not sure what's the purpose of convert_to_base(), it looks like some new calls to it were added by c166625 but then removed in 6da1388, however the function itself had existed before then and I think the calls to it from pre_use() are really necessary...

[Lokimed]

Without my fix not compile exchange(soci::use()) with any const vector<boost::optional<>>
But with const vector<> compile.
Maybe i still not understand all situation.
I neen more time for research.

[Lokimed]

problem is than for const vector<boost::optional> deduced user_type_tag instead basic_type_tag i think.
I try fix it.

[Lokimed]

I did It!!! Soon will be commit

[vadz]

Sorry I'm still not sure if this is the right thing to do... Any comments from the others would be very welcome.

[vadz]

I'm not sure if this really belongs here, wouldn't it be better to add this to the real tests, i.e. to common-tests.h?

[Lokimed]

This test not run every time? Why better move to common-tests.h?
If you insist, i will fix.

[vadz]

This is a bit weird, what do the duplicated statements using this string instead of the literal constant supposed to check?

[Lokimed]

I took so test from "soci/tests/empty/test-empty.cpp". I mean about duplicated statements.
I think aim is check char* and std::sting with operator << work correct and after possible bind values.
My aim is only check bind with vector<boost> with supported type and CONST vector<boost> with supported type.
If you want i can delete part of checks?

[vadz]

Could this be done in include/soci/boost-optional.h? It seems like a more appropriate place for it.

[Lokimed]

I try do this

[Lokimed]

I watched on class

template <typename T> class use_type<std::vector<T> > : public vector_use_type

and also used const_cast

[Lokimed]

Let's wath to class conversion_use_type

template <typename T> class conversion_use_type<std::vector<T> > : private base_vector_holder<T>, public use_type<std::vector<typename type_conversion<T>::base_type> >

---

class base_vector_holder have no method - convert_from_base

---

Let's watch to
class use_type

template <typename T> class use_type<std::vector<T> > : public vector_use_type

Have have no method - convert_from_base

---

Let's watch to
class vector_use_type

Have have no method - convert_from_base

but have method virtual void convert_to_base() {}

---

So if possible usw modern C++ and use override in all pace wheen possible, i think we must get compilation error for class conversion_use_type<std::vector
if mark his methos convert_from_base override.
But class conversion_use_type<std::vector is template. So ithink compiler not create method convert_from_base and we can delete this

[Lokimed]

Is there any problems which i need fix or explain?

[vadz]

Sorry, no, I just didn't have time to address this yet,

I don't think we still need changes in tests/empty/test-empty.cpp, but this is very minor and I can remove them myself when merging.

[Lokimed]

Sorry, no, I just didn't have time to address this yet,

I don't think we still need changes in tests/empty/test-empty.cpp, but this is very minor and I can remove them myself when merging.

Okay i will delete changes in tests/empty/test-empty.cpp soon.

[vadz]

Thanks, this really looks like the right thing to do to me, so even though I still don't fully understand what's going on here (and notably why were all these consts not there since the beginning), I'm going to merge it.

Thanks again!