Add LookbackEndOf (LE) cycle type#78
Merged
Merged
Conversation
saturnflyer
force-pushed
the
feature/lookback-end-of-period
branch
from
e2332b9 to
cba607c
Compare
Adds a new LE notation for cycles that behave like Lookback but round the window boundary to the end of the calendar period, preventing completions from expiring mid-period. Supports D, W, M, Q, Y periods. Added: LookbackEndOf (`LE`) cycle type — lookback window that expires at end of calendar period Version: minor
saturnflyer
force-pushed
the
feature/lookback-end-of-period
branch
from
cba607c to
273ab84
Compare
xsavvyx
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LEcycle type (SOF::Cycles::LookbackEndOf) that behaves like Lookback but rounds the window boundary to the end of the calendar periodLEas a two-character kind (placed beforeLin the alternation)lookback_end_of?to thekind_inquirydelegate list inCycleBehavior
V1LE24Mwith a completion on April 9, 2024 (one day before the exact 24-month boundary):Supports all period types: D, W, M, Q, Y.