Skip to content

[fix/#303] ๐“œ๐”‚๐“Ÿ๐“ช๐“ฐ๐“ฎ QA ๊ด€๋ จ ์ˆ˜์ •#319

Merged
dudwntjs merged 4 commits intodevelopfrom
fix/#303-mypage-qa
Nov 3, 2025
Merged

[fix/#303] ๐“œ๐”‚๐“Ÿ๐“ช๐“ฐ๐“ฎ QA ๊ด€๋ จ ์ˆ˜์ •#319
dudwntjs merged 4 commits intodevelopfrom
fix/#303-mypage-qa

Conversation

@dudwntjs
Copy link
Copy Markdown
Contributor

@dudwntjs dudwntjs commented Nov 2, 2025

๐Ÿ“„ ์ž‘์—… ๋‚ด์šฉ

  • ์†”ํ”Œ๋ฆฌ๋“œ๋กญ๋‹ค์šด ํ…์ŠคํŠธ ํฌ๊ธฐ ๋ณ€๊ฒฝ
  • ๋‹‰๋„ค์ž„ ํ…์ŠคํŠธํ•„๋“œ ๊ธ€์ž์ˆ˜ ์ œํ•œ ๋ฏธํ‘œ์‹œ
๊ตฌํ˜„ ๋‚ด์šฉ iPhone 16 pro ๊ธฐ๊ธฐ๋Œ€์‘์€ ๋„˜์–ด๊ฐ€์กฐใ…Ž
๋“œ๋กญ๋‹ค์šด
ํ…์ŠคํŠธํ•„๋“œ
์˜จ๋ณด๋”ฉ์—์„œ๋Š” ์นด์šดํ„ฐ๊ฐ€ ๋ณด์—ฌ์•ผํ•˜๊ตฌ ๋งˆ์ดํŽ˜์ด์ง€์—์„œ๋Š” ์นด์šดํ„ฐ๊ฐ€ ๋ณด์ด๋ฉด ์•ˆ๋จ

๐Ÿ’ป ์ฃผ์š” ์ฝ”๋“œ ์„ค๋ช…

CounterVisibility enum ์ถ”๊ฐ€

NicknameTextField(
    state: .editing,
    counterVisibility: .whenNotEmpty, // ์ž…๋ ฅํ•˜๋ฉด ๋‚˜ํƒ€๋‚˜๊ธฐ
    onChange: { store.dispatch(.nicknameChanged($0)) },
    onSubmit: { store.dispatch(.nicknameChanged($0)) }
)

๊ธฐ์กด์—๋Š” ํ•ญ์ƒ ์ˆซ์ž ์นด์šดํ„ฐ๊ฐ€ ๋ณด์˜€์œผ๋‚˜, ํ™”๋ฉด๋ณ„๋กœ ๊ตฌ๋ถ„๋˜๋„๋ก ํŒŒ๋ผ๋ฏธํ„ฐ ์ถ”๊ฐ€ํ–‡๋”์šฉ

  • .always : ์ฒ˜์Œ๋ถ€ํ„ฐ ์นด์šดํ„ฐ ํ‘œ์‹œ
  • .whenNotEmpty : ์ž…๋ ฅ์ด ์‹œ์ž‘๋˜๋ฉด ์นด์šดํ„ฐ ํ‘œ์‹œ

๐Ÿ”— ์—ฐ๊ฒฐ๋œ ์ด์Šˆ

@dudwntjs dudwntjs requested a review from a team November 2, 2025 16:30
@dudwntjs dudwntjs self-assigned this Nov 2, 2025
@dudwntjs dudwntjs added โ˜€๏ธ youngju ์˜์ฃผ๊ฐ€ํ•จ! โœ‚๏ธ fix ๋ฒ„๊ทธ๋‚˜ ์˜ค๋ฅ˜ ํ•ด๊ฒฐ ์‹œ ์‚ฌ์šฉ labels Nov 2, 2025
@dudwntjs dudwntjs changed the title Fix/#303 mypage qa [fix/#303] ๐“œ๐”‚๐“Ÿ๐“ช๐“ฐ๐“ฎ QA ๊ด€๋ จ ์ˆ˜์ • Nov 2, 2025
Copy link
Copy Markdown
Collaborator

@SeungWon1125 SeungWon1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum์ถ”๊ฐ€ ๋ง˜์—๋“œ๋„ค์š” ๊ตฟ

@dudwntjs dudwntjs merged commit 3d48913 into develop Nov 3, 2025
@dudwntjs dudwntjs deleted the fix/#303-mypage-qa branch November 3, 2025 07:14
@OneTen19
Copy link
Copy Markdown

OneTen19 commented Nov 3, 2025

ํฐํŠธ๊ฐ€ ๊ฐ•๋ ฌํ•ด์„œ ๋ฉ‹์žˆ์–ด์š”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

โœ‚๏ธ fix ๋ฒ„๊ทธ๋‚˜ ์˜ค๋ฅ˜ ํ•ด๊ฒฐ ์‹œ ์‚ฌ์šฉ โ˜€๏ธ youngju ์˜์ฃผ๊ฐ€ํ•จ!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] ๐“œ๐”‚๐“Ÿ๐“ช๐“ฐ๐“ฎ QA ๊ด€๋ จ ์ˆ˜์ •

3 participants