Merged
Conversation
Closed
1 task
SeungWon1125
approved these changes
Nov 3, 2025
Collaborator
SeungWon1125
left a comment
SeungWon1125
left a comment
There was a problem hiding this comment.
굉장히 빠르네요 ㄷ 고생하셧슴니당 🫡
Comment on lines
+11
to
+16
| let title: String | ||
| let isRequired: Bool | ||
| let isChecked: Bool | ||
| var showsChevron: Bool = false | ||
| let onTap: () -> Void | ||
|
|
Collaborator
There was a problem hiding this comment.
private으로 감추고 생성자 넣어주는 거 어떤가요?
SeungWon1125
approved these changes
Nov 3, 2025
| import Foundation | ||
|
|
||
| struct OnboardingCompleteRequestDTO: RequestModelType { | ||
| struct UserCompleteRequestDTO: Encodable, RequestModelType { |
Collaborator
There was a problem hiding this comment.
여기 RequestModelType만 해도 될 거 같습니닷
Comment on lines
+10
to
+20
| struct UserPoliciesResponseDTO: Decodable, ResponseModelType { | ||
| let userPolicies: [PolicyDTO] | ||
| } | ||
|
|
||
| struct PolicyDTO: Decodable { | ||
| let id: Int | ||
| let policyType: String | ||
| let title: String | ||
| let content: String | ||
| let required: Bool | ||
| } |
Collaborator
There was a problem hiding this comment.
요기도 둘 다 ResponseModelType만 채택해도 될 거 같슴당
Comment on lines
+10
to
+36
| struct OnboardingCompleteInfo: Encodable { | ||
| let policyAgreementInfos: [PolicyAgreementInfo] | ||
| let townId: Int | ||
| let townName: String | ||
| let persona: String | ||
| let nickname: String | ||
|
|
||
| init( | ||
| townId: Int, | ||
| townName: String, | ||
| persona: String, | ||
| nickname: String, | ||
| policyAgreementInfos: [PolicyAgreementInfo] = [] | ||
| ) { | ||
| self.townId = townId | ||
| self.townName = townName | ||
| self.persona = persona | ||
| self.nickname = nickname | ||
| self.policyAgreementInfos = policyAgreementInfos | ||
| } | ||
| } | ||
|
|
||
| struct PolicyAgreementInfo: Encodable { | ||
| let policyId: Int | ||
| let isAgree: Bool | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Entity인데 Encodable을 채택한 이유가 있나요? 궁금
Contributor
Author
There was a problem hiding this comment.
PR에 적혀잇는 부분인데... 잘못 생각햇어요ㅠ
도메인에 policyAgreementInfos 추가 + 기본값 이니셜라이져 햇었고.... 동작은 되지만 설계상 구리구리하다 생각하긴 햇거던요.....
지금 현재 OnboardingCompleteInfo(Entity)가 Encodable을 채택 → 도메인 모델이 네트워크 전송 책임을 지더라구요....?
OnboardingCompleteInfo는 순수 도메인으로 유지하고, 전송은OnboardingCompleteRequestDTO에서 하는 게 맞는 것 같아욤
그럼 Encodable를 굳이 엔티티 단에서 안써도 댐
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 작업 내용
💻 주요 코드 설명
OnboardingCompleteInfo 모델
policyAgreementInfos필드를OnboardingCompleteInfo모델에 추가UserCompleteResponseDTO.toEntity()호출 시policyAgreementInfos인자를 생략할 수 있도록기본값([])을 가지는 커스텀 이니셜라이저를 추가함요
🔗 연결된 이슈
👀 기타 더 이야기해볼 점
어.. 깃 꼬엿는데... 해결햇어요... 어차피 들킬 것 같아서... 말씀드려요