Add institutional partner option to events source type #3207#3619
Conversation
1913d03 to
4a2f5a8
Compare
MateStrysewske
left a comment
There was a problem hiding this comment.
- EventReadFragment is missing in the app
- There should probably also be a srcInstitutionalPartnerTypeDetails text field in case "Other" is chosen (to allow users to specify it); we have this pattern for all other enums that allow the selection of "Other"
Good point ! This is a functional change to be confirmed in the issue with bernard and carolin, I have copy/pasted the question to the issue. |
|
It's done ✔️ |
MateStrysewske
left a comment
There was a problem hiding this comment.
Have you checked and tested the app? E.g. there's an import for InstitutionalPartnerType missing, so the app is unable to build.
Unfortunately, I've never been able to launch the app, following the |
|
@alexandre-gille Okay, I'll take care of that this time. But please make sure to get your Android Studio up and running next week. If you need support, drop me a message at our Gitter (it's linked on the main site of this repository). It's really, really important that you test the stuff you're submitting both in the web as well as the mobile app. |
|
@alexandre-gille Just realised that I of course can't fix this myself because I can't push to your pull request. There's an import for InstitutionalPartnerType missing in Event.java in the mobile app. I'll approve and merge the PR after that's added. |
Closes #3207