Skip to content

Add institutional partner option to events source type #3207#3619

Merged
MateStrysewske merged 13 commits intoSORMAS-Foundation:developmentfrom
GIP-GRADeS-BFC:hzi_3207_institutional_partner
Dec 9, 2020
Merged

Add institutional partner option to events source type #3207#3619
MateStrysewske merged 13 commits intoSORMAS-Foundation:developmentfrom
GIP-GRADeS-BFC:hzi_3207_institutional_partner

Conversation

@alexandre-gille
Copy link
Copy Markdown
Contributor

Closes #3207

@alexandre-gille alexandre-gille force-pushed the hzi_3207_institutional_partner branch from 1913d03 to 4a2f5a8 Compare November 27, 2020 19:19
Copy link
Copy Markdown
Contributor

@MateStrysewske MateStrysewske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • EventReadFragment is missing in the app
  • There should probably also be a srcInstitutionalPartnerTypeDetails text field in case "Other" is chosen (to allow users to specify it); we have this pattern for all other enums that allow the selection of "Other"

@ftavin
Copy link
Copy Markdown

ftavin commented Dec 2, 2020

* There should probably also be a srcInstitutionalPartnerTypeDetails text field in case "Other" is chosen (to allow users to specify it); we have this pattern for all other enums that allow the selection of "Other"

Good point ! This is a functional change to be confirmed in the issue with bernard and carolin, I have copy/pasted the question to the issue.

@alexandre-gille
Copy link
Copy Markdown
Contributor Author

It's done ✔️

Comment thread sormas-api/src/main/java/de/symeda/sormas/api/event/EventExportDto.java Outdated
Comment thread sormas-app/app/src/main/res/layout/fragment_event_read_layout.xml Outdated
Copy link
Copy Markdown
Contributor

@MateStrysewske MateStrysewske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked and tested the app? E.g. there's an import for InstitutionalPartnerType missing, so the app is unable to build.

Comment thread sormas-api/src/main/java/de/symeda/sormas/api/event/EventExportDto.java Outdated
@alexandre-gille
Copy link
Copy Markdown
Contributor Author

Have you checked and tested the app? E.g. there's an import for InstitutionalPartnerType missing, so the app is unable to build.

Unfortunately, I've never been able to launch the app, following the DEVELOPMENT_ENVIRONMENT.md. Hence I cannot test anything at all.
And I don't see where this missing import should be 🤷

@MateStrysewske
Copy link
Copy Markdown
Contributor

@alexandre-gille Okay, I'll take care of that this time. But please make sure to get your Android Studio up and running next week. If you need support, drop me a message at our Gitter (it's linked on the main site of this repository). It's really, really important that you test the stuff you're submitting both in the web as well as the mobile app.

@MateStrysewske
Copy link
Copy Markdown
Contributor

@alexandre-gille Just realised that I of course can't fix this myself because I can't push to your pull request. There's an import for InstitutionalPartnerType missing in Event.java in the mobile app. I'll approve and merge the PR after that's added.

@MateStrysewske MateStrysewske merged commit a6ee61a into SORMAS-Foundation:development Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "health insure agency" as category to variable “Source Type” (EVENT)

3 participants