fix: Add SQL output length limits to prevent DoS (fixes #33) #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #33 by implementing SQL output length limits to prevent Denial of Service attacks through resource exhaustion from extremely large SQL output.
Changes
Core Implementation
defaultMaxSQLOutputLength = 50000constant - Default limit for generated SQLWithMaxOutputLength()option - Allows customization of output length limitvisit()method - Validates SQL length at each recursion pointConvert()andConvertParameterized()- Both respect the output length limitTests (
output_length_test.go)Comprehensive test coverage including:
Documentation
CLAUDE.mdwith new "Resource Exhaustion Protection" sectionREADME.mdsecurity features to include SQL output length limitsWithMaxOutputLength()Security Impact
WithMaxOutputLength())Example Usage
Testing
make test)make lint)Related Issue
Fixes #33
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com