Add add-cel-feature agent skill#12
Merged
richardwooding merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
Captures the procedure for adding a new CEL function / operator / macro / comprehension form to pycel2sql. Mirrors the cel2sql Go and cel2sql4j Java equivalents but adapted to Lark visitor naming and the Python Dialect ABC. Layout under .claude/skills/add-cel-feature/: - SKILL.md (~120 lines) — quick start, "new method or inline?" decision table, where features live in _converter.py, parser-level constraints, test coverage map, verification. - references/converter-file-map.md — every visitor / helper section in _converter.py, grouped by CEL surface, with line-number anchors and one-line "what it owns" descriptions. Cribbed from the cel2sql Go equivalent and adapted to the Lark visitor naming. The SKILL.md notes the Dialect ABC method checklist lives in the add-sql-dialect skill (cross-skill reference by path string, not link — the lint forbids cross-skill links). Lints clean against .claude/skills/skill-authoring/scripts/lint_skill.py. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second of four maintenance skills (per the plan). Captures the procedure for adding a new CEL function / operator / macro / comprehension form to pycel2sql across all six dialects.
Mirrors the equivalent skill in cel2sql Go (`add-cel-feature`) and cel2sql4j Java (`add-cel-function`), adapted to Lark visitor naming and Python's `Dialect` ABC.
Layout
The `Dialect` ABC method checklist lives in the `add-sql-dialect` skill (PR #11). The two skills share that file by file-path reference, not by markdown link — the lint forbids cross-skill links.
Lint
```
$ python .claude/skills/skill-authoring/scripts/lint_skill.py .claude/skills/add-cel-feature/
0 error(s), 0 warning(s)
```
Test plan
🤖 Generated with Claude Code