feat(shortcut): 增加提示,设置完快捷键后 blur 输入框#1042
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the shortcut recording component by adding instructional popovers and ensuring the input field is blurred after interactions. It also introduces a check to prevent redundant updates. A review comment suggests refactoring the isSameShortcut function to ensure consistent handling of global shortcut formatting and avoid redundant success messages.
template 部分没怎么改,套了一层 n-popover(加提示),改了一下 placeholder 的提示文字 onKeyDown 部分优化了体验,在设置完成快捷键后会自动 blur 掉输入框,删除快捷键和快捷键相同时增加了提示 ~~不会就我不知道怎么取消设置快捷键,按 Esc 没法取消,看了代码才知道是 Backspace 吧?(~~
imsyy
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
template 部分没怎么改,套了一层 n-popover(加提示),改了一下 placeholder 的提示文字
onKeyDown 部分优化了体验,在设置完成快捷键后会自动 blur 掉输入框,删除快捷键和快捷键相同时增加了提示
不会就我不知道怎么取消设置快捷键,按 Esc 没法取消,看了代码才知道是 Backspace 吧?(