Skip to content

fix(FullPlayer): lyricsBlendMode 在重新打开 FullPlayer 后不生效#961

Merged
imsyy merged 2 commits into
SPlayer-Dev:devfrom
MoYingJi:pr/f
Mar 7, 2026
Merged

fix(FullPlayer): lyricsBlendMode 在重新打开 FullPlayer 后不生效#961
imsyy merged 2 commits into
SPlayer-Dev:devfrom
MoYingJi:pr/f

Conversation

@MoYingJi
Copy link
Copy Markdown
Collaborator

@MoYingJi MoYingJi commented Mar 1, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 1, 2026 09:47
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the FullPlayer component where the lyricsBlendMode setting failed to persist or reapply correctly after the player was closed and reopened. The fix involves a change in how the blend mode is applied, transitioning from a direct Vue v-bind in scoped styles to using a CSS custom property, ensuring the visual effect remains consistent and reactive throughout the component's lifecycle.

Highlights

  • lyricsBlendMode Fix: Resolved an issue where the lyricsBlendMode setting would not correctly apply after the FullPlayer component was reopened, leading to inconsistent visual effects.
  • CSS Variable Implementation: Refactored the application of lyricsBlendMode by introducing a CSS custom property (--lyric-blend-mode) on the main player element, which is then referenced within the component's scoped styles. This ensures dynamic updates and persistence across component lifecycle events.
Changelog
  • src/components/Player/FullPlayer.vue
    • Fixed an issue where lyricsBlendMode was not applied correctly after the player was reopened.
    • Updated mix-blend-mode to use a CSS custom property for better reactivity.
Activity
  • No specific activity or comments have been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

此 PR 修复 FullPlayer 重新打开后“歌词混合模式(lyricsBlendMode)”不生效的问题:将原本在 scoped CSS 中通过 v-bind() 注入的值,改为在 FullPlayer 根节点写入 CSS 自定义属性,并在样式中通过 var() 引用,确保每次挂载/重新打开时都能正确带上最新的设置值。

Changes:

  • 在 FullPlayer 根元素上新增 --lyric-blend-mode CSS 变量绑定到 settingStore.lyricsBlendMode
  • .content-rightmix-blend-modev-bind() 改为 var(--lyric-blend-mode) 取值

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 修复了在重新打开全屏播放器后 lyricsBlendMode 不生效的问题。您将 mix-blend-mode 的值从使用 v-bind 动态绑定改为使用在组件根元素上通过内联样式定义的 CSS 自定义属性。这种方法可以更可靠地在组件重新挂载时应用动态样式。代码实现清晰,没有发现明显问题。

@MoYingJi
Copy link
Copy Markdown
Collaborator Author

MoYingJi commented Mar 1, 2026

lyricsBlendMode 目前还有一个 BUG 是设置为 plus-lighter 的时候切歌会闪一下(表现为先为 screen 然后突然切换到 plus-lighter?)

@imsyy imsyy merged commit a051978 into SPlayer-Dev:dev Mar 7, 2026
@MoYingJi MoYingJi deleted the pr/f branch March 11, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants