Skip to content

Fix PboEntryBuffer::xsgetn not confirming to C++ standard #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
X39 merged 1 commit into from
Jul 19, 2020
Merged

Fix PboEntryBuffer::xsgetn not confirming to C++ standard #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/parsing/parsepbo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ int PboEntryBuffer::underflow() {
return std::char_traits<char>::to_int_type(*this->gptr());
}

int64_t PboEntryBuffer::xsgetn(char* _Ptr, int64_t _Count) {
std::streamsize PboEntryBuffer::xsgetn(char* _Ptr, std::streamsize _Count) {
// get _Count characters from stream
const int64_t _Start_count = _Count;

Expand Down
2 changes: 1 addition & 1 deletion src/parsing/parsepbo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class PboEntryBuffer : public std::streambuf {

void setBufferSize(size_t newSize);
int underflow() override;
int64_t xsgetn(char* _Ptr, int64_t _Count) override;
std::streamsize xsgetn(char* _Ptr, std::streamsize _Count) override;
pos_type seekoff(off_type, std::ios_base::seekdir, std::ios_base::openmode) override;
pos_type seekpos(pos_type, std::ios_base::openmode) override;
std::streamsize showmanyc() override;
Expand Down