Enhance extension loading#132
Merged
X39 merged 2 commits intoSQFvm:masterfrom Nov 18, 2020
dextercd:master
Merged
Conversation
The code checks whether or not the library has already been loaded by looking at the path() of every loaded dlops object. For Linux ".so" is appended before loading the library, but this is not appended when checking whether it's loaded. This causes the library to get added to the dlops list multiple times. This patch fixes the issue by introducing a new variable that has the required platform dependent suffix and uses that for the comparisons and loading. The `name` variable stays unchanged so that the logging messages uses the extension name as it appears in sqf.
Collaborator
|
I am not sure how this slipped through my inbox ... |
Contributor
Author
|
No worries. Thank you for merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with loading extensions on Linux and loads '_x64' extensions when the project has been compiled for 64 bits.