Skip to content

Running 'sqlmesh test' no longer displays dots for successful test cases #2656

@giovannipcarvalho

Description

@giovannipcarvalho

I noticed a few versions ago that sqlmesh test stopped logging ... for successes.

Bisecting through the revisions I pinpointed it to the introduction of the method addSuccess for the class ModelTextTestResult in d8ff3fd.

I think the original behavior is a very helpful visual feedback of test progression and this seems like a minor oversight.

repro:

λ uv venv
Using Python 3.11.8 interpreter at: /home/giovanni/.local/bin/python
Creating virtualenv at: .venv
Activate with: source .venv/bin/activate

λ . .venv/bin/activate
λ uv pip install sqlmesh==v0.78.2
Resolved 52 packages in 795ms
Downloaded 1 package in 630ms
Installed 52 packages in 54ms
 [...]
λ sqlmesh init duckdb
λ sqlmesh test
.    <-------- dots are printed
----------------------------------------------------------------------
Ran 1 test in 0.020s

OK

λ uv pip install sqlmesh==v0.78.3
Resolved 52 packages in 284ms
Downloaded 1 package in 719ms
Installed 1 package in 19ms
 - sqlmesh==0.78.2
 + sqlmesh==0.78.3

λ rm -f db.db && sqlmesh test
    <-------- dots are missing
----------------------------------------------------------------------
Ran 1 test in 0.020s

OK

for completeness, it still happens on the latest version

λ uv pip install sqlmesh --upgrade
Resolved 53 packages in 82ms
Installed 4 packages in 10ms
 + freezegun==1.5.1
 - sqlglot==22.5.0
 + sqlglot==23.17.0
 - sqlglotrs==0.1.2
 + sqlglotrs==0.2.5
 - sqlmesh==0.78.3
 + sqlmesh==0.97.0

λ rm -f db.db && sqlmesh test

----------------------------------------------------------------------
Ran 1 test in 0.022s

OK

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions