Skip to content

Fix!(tests): normalize identifiers according to the config's dialect#1206

Merged
georgesittas merged 9 commits intomainfrom
jo/schema_normalization_fixes
Aug 3, 2023
Merged

Fix!(tests): normalize identifiers according to the config's dialect#1206
georgesittas merged 9 commits intomainfrom
jo/schema_normalization_fixes

Conversation

@georgesittas
Copy link
Contributor

@georgesittas georgesittas commented Jul 24, 2023

Fixes #1205

  • Normalize various needed model meta fields.
  • Normalize unit test identifiers to fix resolution discrepancies.
  • Add tests.

@georgesittas georgesittas marked this pull request as draft July 28, 2023 16:01
@georgesittas georgesittas force-pushed the jo/schema_normalization_fixes branch 2 times, most recently from 48fd033 to 98ceea6 Compare August 1, 2023 18:35
@georgesittas georgesittas marked this pull request as ready for review August 1, 2023 18:35
@georgesittas georgesittas force-pushed the jo/schema_normalization_fixes branch from f66d2f4 to 3efb6d2 Compare August 2, 2023 15:24
@georgesittas georgesittas force-pushed the jo/schema_normalization_fixes branch from ed04589 to 1df5512 Compare August 3, 2023 01:12
@georgesittas georgesittas changed the title Fix: normalize schema identifiers for seed and python models Fix!(tests): normalize identifiers according to the config's dialect Aug 3, 2023
@georgesittas georgesittas force-pushed the jo/schema_normalization_fixes branch from 6f7c200 to 12efa60 Compare August 3, 2023 22:42
@georgesittas georgesittas requested a review from a team August 3, 2023 22:57
@georgesittas georgesittas merged commit e86a891 into main Aug 3, 2023
@georgesittas georgesittas deleted the jo/schema_normalization_fixes branch August 3, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with snowflake dialect when following the "Get started" instructions

2 participants