Feat: Use table clones instead of temp tables in dev environments for engines that support this#1364
Merged
izeigerman merged 2 commits intomainfrom Aug 30, 2023
Merged
Conversation
Contributor
|
Can you include Databricks in this? We assume currently in the Databricks engine is using Delta and therefore supports clones. Make sure to do a shallow clone. |
izeigerman
force-pushed
the
feat-support-table-clonining-in-dev-envs
branch
from
f5415ca to
fc73797
Compare
Contributor
Author
|
Good point, @eakmanrq , added |
tobymao
approved these changes
Aug 30, 2023
Contributor
tobymao
left a comment
tobymao
left a comment
There was a problem hiding this comment.
that was easier than i thought?
Contributor
Author
|
@tobymao, yeah, that's why Ryan and I didn't anticipate any complexity here. |
Contributor
|
@izeigerman you are missing the |
Contributor
Author
|
@eakmanrq fixed databricks support. Please revisit |
… engines that support this
izeigerman
force-pushed
the
feat-support-table-clonining-in-dev-envs
branch
from
a41e708 to
e71749b
Compare
eakmanrq
reviewed
Aug 30, 2023
eakmanrq
reviewed
Aug 30, 2023
eakmanrq
approved these changes
Aug 30, 2023
crericha
reviewed
Aug 30, 2023
| **kwargs: t.Any, | ||
| ) -> None: | ||
| clone_kwargs = clone_kwargs or {} | ||
| clone_kwargs["shallow"] = True |
Contributor
There was a problem hiding this comment.
Do we want to enforce shallow or only set to True if not in kwargs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.