Fix: Move columns and rendered query to separate tabs in Editor inspector#1477
Merged
Fix: Move columns and rendered query to separate tabs in Editor inspector#1477
Conversation
Contributor
mykalmax
commented
Sep 25, 2023
mykalmax
commented
vchan
approved these changes
Sep 25, 2023
Comment on lines
+128
to
+130
| nodeId={model.name} | ||
| columns={model.columns} | ||
| disabled={model?.type === 'python'} |
Contributor
There was a problem hiding this comment.
Do nodeId and columns need optional chaining on model too?
Contributor
Author
There was a problem hiding this comment.
model should be present so model?.type here does not need chaining
Co-authored-by: Vincent Chan <vchan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.