Fix: Add Proper Catalog Support to Engine Adapter#1559
Merged
Conversation
eakmanrq
commented
Oct 11, 2023
0dcf4eb to
3bee118
Compare
tobymao
reviewed
Oct 11, 2023
tobymao
reviewed
Oct 11, 2023
tobymao
reviewed
Oct 11, 2023
tobymao
reviewed
Oct 11, 2023
tobymao
reviewed
Oct 11, 2023
3bee118 to
87976de
Compare
tobymao
reviewed
Oct 11, 2023
tobymao
reviewed
Oct 11, 2023
tobymao
reviewed
Oct 11, 2023
tobymao
reviewed
Oct 11, 2023
tobymao
reviewed
Oct 11, 2023
tobymao
reviewed
Oct 11, 2023
c667bca to
a6845f3
Compare
tobymao
reviewed
Oct 12, 2023
tobymao
reviewed
Oct 12, 2023
tobymao
approved these changes
Oct 12, 2023
tobymao
reviewed
Oct 12, 2023
fdb8f2d to
5fe9689
Compare
5fe9689 to
1a386d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Controversial change to highlight: Removed the field
catalog_nameand instead let callers provide aTableNamewhich means it can either be a string orexp.Tableobject.Added engine adapter methods:
get_current_catalogset_current_catalogNew Property:
CatalogSupportThis tells the
set_catalogdecorator what level of catalog support the engine adapter has in order to set the catalog properly. 3 levels:Requires Set Catalogmeans that operations cannot be provided with the catalog but instead they needset_current_catalogagainst the catalog and then they can provide the operation but now with the catalog dropped. This always refers to the target of the operation (ex: if drop schema, the schema being drooped) and we assume reads can happen across catalogs. For engines that don't support reads across catalogs we just consider them Unsupported (ex: Postgres).Follow up work: