Fix!: show proper pip install command when sqlmesh schema version is behind#1638
Merged
georgesittas merged 3 commits intomainfrom Oct 31, 2023
Merged
Fix!: show proper pip install command when sqlmesh schema version is behind#1638georgesittas merged 3 commits intomainfrom
georgesittas merged 3 commits intomainfrom
Conversation
georgesittas
force-pushed
the
jo/get_versions_ux_improvement
branch
from
bc8f092 to
97a3aaf
Compare
tobymao
approved these changes
Oct 31, 2023
izeigerman
reviewed
Oct 31, 2023
georgesittas
force-pushed
the
jo/get_versions_ux_improvement
branch
from
97a3aaf to
5dfafe1
Compare
izeigerman
approved these changes
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior:
The suggested command is incorrect because we're interpolating
versions.schema_versioninstead of the actual SQLMesh package version. To overcome this issue I added a new columnsqlmesh_versionto the_versionsstate table which is currently only used to improve the UX when an error message is raised.