Conversation
izeigerman
approved these changes
Nov 2, 2023
treysp
approved these changes
Nov 2, 2023
eakmanrq
force-pushed
the
eakmanrq/fix_spark_temp_table
branch
from
e1b112b to
96e2d2d
Compare
eakmanrq
commented
Nov 2, 2023
| def replace_table( | ||
| node: exp.Expression, curr_table: exp.Table, new_table: exp.Table | ||
| ) -> exp.Expression: | ||
| if isinstance(node, exp.Table) and quote_identifiers(node) == quote_identifiers( |
Contributor
Author
There was a problem hiding this comment.
@treysp FYI I think this was another bug outside of the spark issue. node == curr_table could say that two tables don't match if one doesn't have quotes and the other does. So we quote them both now when comparing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears when writing local files with spark it does not like a table that starts with double underscore. So I updated temp table for spark to remove it.
Also re-organized things a bit to remove the pattern where we got a query from source query and then made a source query again.