Feat: Support model selection for backfilling when running a plan against a dev environment#1692
Conversation
docs/reference/cli.md
Outdated
There was a problem hiding this comment.
can this support multiple? should it be models?
sqlmesh/cli/main.py
Outdated
There was a problem hiding this comment.
No, see --select-model and --restate-model. Multiple entires in CLI look like following:
sqlmesh plan --backfill-model model_a --backfill-model "<expression>"
sqlmesh/core/plan/definition.py
Outdated
There was a problem hiding this comment.
do we need to be so strict?
There was a problem hiding this comment.
I strongly believe so. Why would anyone want to backfill prod partially?
There was a problem hiding this comment.
I agree with being strict here unless we hear a good use case. The product is opinionated about characteristics that make up prod and we so far this seems like a good bet.
sqlmesh/core/plan/definition.py
Outdated
There was a problem hiding this comment.
so this will select all models upstream of models selected to ensure the chain is proper right
izeigerman
force-pushed
the
feat-select-models-for-backfill-in-plan
branch
from
f81204f to
a1b5950
Compare
docs/reference/cli.md
Outdated
There was a problem hiding this comment.
it was mentioned twice
|
this is a breaking change because you're changing user facing cli |
docs/reference/cli.md
Outdated
There was a problem hiding this comment.
does this support special syntax?
There was a problem hiding this comment.
For example did we decide to not support a syntax for saying directly modified only?
There was a problem hiding this comment.
Depends on what you mean by a special syntax. If you mean +, *, etc. then yes. If you mean directly modified, then no. I realized supporting directly modified doesn't have much value.
…inst a dev environment
izeigerman
force-pushed
the
feat-select-models-for-backfill-in-plan
branch
from
a1b5950 to
8fe8cec
Compare
3 participants
No description provided.