Skip to content

feat: add model tag restatement selector#1908

Merged
eakmanrq merged 2 commits intomainfrom
eakmanrq/add_model_restate_tag_selector
Jan 2, 2024
Merged

feat: add model tag restatement selector#1908
eakmanrq merged 2 commits intomainfrom
eakmanrq/add_model_restate_tag_selector

Conversation

@eakmanrq
Copy link
Contributor

No description provided.

@eakmanrq eakmanrq force-pushed the eakmanrq/add_model_restate_tag_selector branch from 1587744 to ed02f35 Compare December 29, 2023 00:34
@izeigerman
Copy link
Contributor

izeigerman commented Dec 29, 2023

Rather than adding new arguments like --restate-tag, --select-tag, etc., can we instead extend the model selection syntax to incorporate tags? Eg. --select-model tag:my_tag?

@eakmanrq
Copy link
Contributor Author

Rather than adding new arguments like --restate-tag, --select-tag, etc., can we instead extend the model selection syntax to incorporate tags? Eg. --select-model tag:my_tag?

Great suggestion will do.

@eakmanrq eakmanrq force-pushed the eakmanrq/add_model_restate_tag_selector branch from 6405a2c to 8212c69 Compare December 30, 2023 00:25
@eakmanrq eakmanrq requested a review from izeigerman December 30, 2023 00:34
@eakmanrq eakmanrq force-pushed the eakmanrq/add_model_restate_tag_selector branch from 8212c69 to e30e60a Compare January 2, 2024 18:48
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't do this then you will have a diff since you are including snapshots and other configuration in plan.

@izeigerman
Copy link
Contributor

@eakmanrq Just to confirm: this update doesn't cover using a superset of models from both the local state and the target environment?

@eakmanrq
Copy link
Contributor Author

eakmanrq commented Jan 2, 2024

@izeigerman
Copy link
Contributor

@eakmanrq yes, thank you, overlooked that

@eakmanrq eakmanrq force-pushed the eakmanrq/add_model_restate_tag_selector branch from e30e60a to c4b5bf6 Compare January 2, 2024 20:41
@eakmanrq eakmanrq force-pushed the eakmanrq/add_model_restate_tag_selector branch from c4b5bf6 to f45852e Compare January 2, 2024 21:05
@eakmanrq eakmanrq enabled auto-merge (squash) January 2, 2024 21:08
@eakmanrq eakmanrq merged commit c1bae5d into main Jan 2, 2024
@eakmanrq eakmanrq deleted the eakmanrq/add_model_restate_tag_selector branch January 2, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants