Conversation
94d9c70 to
532e5c5
Compare
532e5c5 to
9c37c6e
Compare
izeigerman
approved these changes
Jan 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined with the improvements from #1939 it seems like we can now parallelize all tests except for Airflow.
workstealapproach means that workers can take work from other workers if they finish their queue early (shared/greedy approach).From some simple testing, it seems like assigning 2 workers per code is ideal on CircleCI so updated config to match that. Tests are now 3x faster on CircleCI than prior to these two PRs.