Fix: pass dialect to name field value converter#1949
Merged
eakmanrq merged 2 commits intoSQLMesh:mainfrom Jan 10, 2024
Merged
Conversation
Contributor
|
@z3z1ma This looks really great, thank you 👍 Any chance you can add a small test for this? Good to go otherwise |
tobymao
reviewed
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External models are written like this:
But they fail when the method render definition is called due to the meta converter lookup not having a dialect argument.
This PR fixes that with what is likely the correct behavior