fix: ignore external models during cleanup#1957
Merged
Conversation
eakmanrq
force-pushed
the
eakmanrq/cleanup_ignore_external_models
branch
from
2c9f136 to
1fa36dc
Compare
tobymao
reviewed
Jan 11, 2024
tobymao
reviewed
Jan 11, 2024
tests/core/test_context.py
Outdated
Contributor
There was a problem hiding this comment.
interesting comment. glad we have this fixed now
eakmanrq
force-pushed
the
eakmanrq/cleanup_ignore_external_models
branch
from
1fa36dc to
860c66f
Compare
tobymao
approved these changes
Jan 11, 2024
izeigerman
approved these changes
Jan 11, 2024
eakmanrq
force-pushed
the
eakmanrq/cleanup_ignore_external_models
branch
from
860c66f to
27cd6a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.