Render handles for Model Column only when that column selected#1994
Merged
Render handles for Model Column only when that column selected#1994
Conversation
Render Lineage node handles for Model Column only when that column has been select to build column level lineage
mykalmax
commented
Jan 20, 2024
| } | ||
| }, [lineageIndex, withColumns]) | ||
|
|
||
| useEffect(() => { |
Contributor
Author
There was a problem hiding this comment.
redundant sinse will be updated in next useEffect anyways
mykalmax
commented
Jan 20, 2024
| withConnected: boolean = true, | ||
| withImpacted: boolean = true, | ||
| withSecondary: boolean = true, | ||
| withColumns: boolean = true, |
Contributor
Author
There was a problem hiding this comment.
withColumns triggers rebuilding and repositioning of the lineage sinse node with columns has different height, so no need for additionally update
mykalmax
changed the title
vchan
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render Lineage node handles for Model Column only when that column has been selected to build column level lineage. Rendering handles (blue circle on screenshot) for all nodes with columns upfront slows down rendering lineage and creates unnecessary html elements
Also, show columns for nodes when
withColumns: false: