Fix: When deleting expired snapshots in janitor only fetch relevant snapshot records#2030
Merged
izeigerman merged 2 commits intomainfrom Jan 26, 2024
Merged
Conversation
izeigerman
force-pushed
the
fix-only-fetch-expired-snapshots-in-janitor
branch
from
bed8dca to
189dcae
Compare
izeigerman
force-pushed
the
fix-only-fetch-expired-snapshots-in-janitor
branch
from
189dcae to
0578772
Compare
tobymao
reviewed
Jan 26, 2024
izeigerman
force-pushed
the
fix-only-fetch-expired-snapshots-in-janitor
branch
from
04067de to
0936d09
Compare
tobymao
approved these changes
Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the janitor process would fetch all snapshot records to figure out what needs to be cleaned up. This led to a large memory footprint for projects with many models and / or changes.
This update ensures that only records that actually expired are fetched from the state DB.