Fix: Fetch snapshot records on demand when generating Airflow dags#2032
Merged
izeigerman merged 2 commits intomainfrom Jan 27, 2024
Merged
Conversation
izeigerman
force-pushed
the
fix-fetch-snapshots-on-demand-when-generating-airflow-dags
branch
from
7949c51 to
6c25bfc
Compare
tobymao
approved these changes
Jan 26, 2024
tobymao
reviewed
Jan 26, 2024
Contributor
There was a problem hiding this comment.
so this is the main change right? you got rid of this
izeigerman
force-pushed
the
fix-fetch-snapshots-on-demand-when-generating-airflow-dags
branch
from
6c25bfc to
8036d9b
Compare
izeigerman
force-pushed
the
fix-fetch-snapshots-on-demand-when-generating-airflow-dags
branch
from
28d7795 to
4a987e7
Compare
izeigerman
deleted the
fix-fetch-snapshots-on-demand-when-generating-airflow-dags
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we fetch all snapshots on the scheduler side which may lead to high memory consumption there. Additionally we had passed all these snapshots into underlying DAG tasks potentially causing high memory consumption at the execution time which could lead to tasks being SIGKILLed.