Skip to content

fix: minor lineage search visual issues #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caiters merged 3 commits into from
Jan 30, 2024
Merged

fix: minor lineage search visual issues #2047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1d20ad
fix: lineage search box light mode and search overlay no longer persi…
caiters Jan 29, 2024
3161ec5
fixing a padding jump on smaller sizes
caiters Jan 30, 2024
a1b7804
search overlay placement
caiters Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/client/src/library/components/graph/ModelLineage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ function GraphControls({ nodes = [] }: { nodes: Node[] }): JSX.Element {
<div className="px-2 flex items-center text-xs text-neutral-400 @container">
<div className="contents">
<Popover
className="flex @lg:hidden bg-none border-none py-1"
className="flex @lg:hidden bg-none border-none"
aria-label="Show lineage node details"
>
<Popover.Button
Expand Down
2 changes: 1 addition & 1 deletion web/client/src/library/components/graph/ModelLineageSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export default function ModelLineageSearch({
className={clsx(
'w-full',
showSearchInput
? 'block absolute left-0 right-0 z-10 pr-10 bg-dark'
? 'block absolute top-0 left-0 right-0 z-10 pr-10 bg-light dark:bg-dark @[40rem]:items-end @[40rem]:justify-end @[40rem]:flex @[40rem]:static @[40rem]:pr-0'
: 'items-end justify-end flex',
)}
>
Expand Down