Skip to content

Chore: Remove command from slack notification#2073

Merged
vchan merged 1 commit intomainfrom
vchan/chore-notification-command
Feb 1, 2024
Merged

Chore: Remove command from slack notification#2073
vchan merged 1 commit intomainfrom
vchan/chore-notification-command

Conversation

@vchan
Copy link
Contributor

@vchan vchan commented Feb 1, 2024

The command arguments could have sensitive information. Removing the command from notifications for now. Will add it back with the sensitive information redacted in the near future.

@vchan vchan requested a review from a team February 1, 2024 18:23
@CLAassistant
Copy link

CLAassistant commented Feb 1, 2024

CLA assistant check
All committers have signed the CLA.

@vchan vchan merged commit 6870b76 into main Feb 1, 2024
@vchan vchan deleted the vchan/chore-notification-command branch February 1, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants