Fix: differentiate seed date and datetime types#2122
Merged
Conversation
treysp
force-pushed
the
trey/seed-date-type
branch
from
9667370 to
ab8d040
Compare
tobymao
approved these changes
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For seed models, SQLMesh currently converts columns from string to all date/time types using
pd.to_datetime(), which always returns apd.Timestamptype.If a user specifies a column as type
DATEin the model definition, the above approach creates a discrepancy between the Pandas dataframe type (timestamp) and the SQL engine type (date). For DuckDB, this results in an error.This PR differentiates conversion for date and datetime types, converting the former into
datetime.dateobjects instead of pandas timestamps.