Feat: ignore SQL model unit test row order unless query contains ORDER BY#2133
Merged
Feat: ignore SQL model unit test row order unless query contains ORDER BY#2133
Conversation
tobymao
reviewed
Feb 16, 2024
treysp
force-pushed
the
trey/test-row-order
branch
from
f23b9f1 to
383efaa
Compare
georgesittas
approved these changes
Feb 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLMesh unit tests currently require the rows returned by the test query to be in the same order as the output rows specified in the test definition. Different engines may return query rows in different orders, meaning the same unit test will pass on some engines and fail on others.
This PR makes SQL model unit tests row-order agnostic unless the model outer SELECT contains an
ORDER BYclause (or a CTE's outer SELECT for CTE-specific tests).Python model tests are order-dependent because there is no universally reliable way to determine whether the model orders the rows.