feat: propogate descriptions in the ui if they are simply pass throug…#2145
Merged
feat: propogate descriptions in the ui if they are simply pass throug…#2145
Conversation
izeigerman
reviewed
Feb 20, 2024
izeigerman
reviewed
Feb 20, 2024
izeigerman
reviewed
Feb 20, 2024
vchan
reviewed
Feb 20, 2024
tobymao
force-pushed
the
toby/column_description_propogation
branch
2 times, most recently
from
86f43fd to
238aa26
Compare
Contributor
Author
|
@vchan merging this after tests pass |
…h and don't have multiple sources
tobymao
force-pushed
the
toby/column_description_propogation
branch
from
238aa26 to
b90b834
Compare
rexledesma
added a commit
to dagster-io/dagster
that referenced
this pull request
Mar 27, 2024
## Summary & Motivation Use the full relation name to index back into the dbt manifest, rather than just using the table identifier. The previous implementation was actually insufficient. Here, we caught more lineage that we missed in the initial algorithm. This now essentially matches the implementation from SQLMesh/sqlmesh#2145. ## How I Tested These Changes pytest
PedramNavid
pushed a commit
to dagster-io/dagster
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation Use the full relation name to index back into the dbt manifest, rather than just using the table identifier. The previous implementation was actually insufficient. Here, we caught more lineage that we missed in the initial algorithm. This now essentially matches the implementation from SQLMesh/sqlmesh#2145. ## How I Tested These Changes pytest
rexledesma
added a commit
to dagster-io/dagster
that referenced
this pull request
Mar 29, 2024
## Summary & Motivation Use the full relation name to index back into the dbt manifest, rather than just using the table identifier. The previous implementation was actually insufficient. Here, we caught more lineage that we missed in the initial algorithm. This now essentially matches the implementation from SQLMesh/sqlmesh#2145. ## How I Tested These Changes pytest
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Feb 25, 2025
…o#20696) ## Summary & Motivation Use the full relation name to index back into the dbt manifest, rather than just using the table identifier. The previous implementation was actually insufficient. Here, we caught more lineage that we missed in the initial algorithm. This now essentially matches the implementation from SQLMesh/sqlmesh#2145. ## How I Tested These Changes pytest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…h and don't have multiple sources