Fix: convert pandas timestamp to py datetime for unit test generation#2149
Merged
Fix: convert pandas timestamp to py datetime for unit test generation#2149
Conversation
treysp
force-pushed
the
trey/unit-test-pd-timestamp
branch
2 times, most recently
from
ad2090c to
8dd66f2
Compare
Contributor
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Is this currently tested in the integration suite? Should we also add a unit test for this?
georgesittas
approved these changes
Feb 20, 2024
Contributor
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Discussed in Slack about changing the for loop order for perf. reasons, but other than that LGTM 👍
treysp
force-pushed
the
trey/unit-test-pd-timestamp
branch
2 times, most recently
from
6c8cbea to
93c7884
Compare
treysp
force-pushed
the
trey/unit-test-pd-timestamp
branch
from
93c7884 to
acd3ee5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem/background
generate_test()creates a SQLMesh unit test YAML file based on a user-specified model name and input querypd.Timestamptype (at least when queries run on DuckDB)ruamel.yamlto serialize the data values returned by the query to YAML, and it does not supportpd.TimestampobjectsThis PR
DATE, we extract the date component from thedatetimeobject before writing so a time component of00:00:00isn't included in the YAML.