Chore:! bump sqlglot to v22.0.1 (got rid of Subqueryable, Unionable)#2174
Merged
georgesittas merged 6 commits intomainfrom Feb 26, 2024
Merged
Chore:! bump sqlglot to v22.0.1 (got rid of Subqueryable, Unionable)#2174georgesittas merged 6 commits intomainfrom
georgesittas merged 6 commits intomainfrom
Conversation
tobymao
approved these changes
Feb 23, 2024
Contributor
tobymao
left a comment
tobymao
left a comment
There was a problem hiding this comment.
probably a major for sqlglot
Contributor
Author
Sure, can edit the title whenever we bump |
georgesittas
force-pushed
the
jo/bump_sqlglot_21_3_0
branch
from
24b49b6 to
9328aa7
Compare
georgesittas
changed the title
tobymao
approved these changes
Feb 26, 2024
georgesittas
changed the title
georgesittas
force-pushed
the
jo/bump_sqlglot_21_3_0
branch
from
5035e49 to
b2f8f78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is early in anticipation of tobymao/sqlglot@2507aa2 (TL;DR merged
SubqueryableandUnionableintoQuery).Initial motivation was to fix #2137 but after discussion we decided it would be generally good to consolidate these two classes. I haven't fully investigated what this means for SQLMesh - these changes were made using search-and-replace, but I intend to audit them more closely soon. I verified that at least
make style && make fast-testpassed locally.