Fix: temporarily unwrap sushi.customers's query again#2191
Merged
georgesittas merged 1 commit intomainfrom Feb 28, 2024
Merged
Conversation
treysp
approved these changes
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though 3b970bd passed all tests in CI, @vchan came across a couple of issues when computing the lineage of
sushi.customers. After chatting we realized it's a bit more involved to fix them, because we'll need to update either SQLGlot's lineage or scope module (or both), so I'm temporarily reverting this change to unblock new releases.