Skip to content

fix: quote identifiers migration statements #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eakmanrq merged 1 commit into from
Mar 2, 2024
Merged

fix: quote identifiers migration statements #2206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions sqlmesh/core/state_sync/engine_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,7 +994,8 @@ def _migrate_snapshot_rows(self) -> t.Dict[SnapshotId, SnapshotTableInfo]:
raw_snapshots = {
SnapshotId(name=name, identifier=identifier): raw_snapshot
for name, identifier, raw_snapshot in self.engine_adapter.fetchall(
exp.select("name", "identifier", "snapshot").from_(self.snapshots_table).lock()
exp.select("name", "identifier", "snapshot").from_(self.snapshots_table).lock(),
quote_identifiers=True,
)
}
if not raw_snapshots:
Expand Down Expand Up @@ -1129,7 +1130,10 @@ def _migrate_seed_rows(self, snapshot_mapping: t.Dict[SnapshotId, SnapshotTableI
seeds = {
SnapshotId(name=name, identifier=identifier): content
for name, identifier, content in self.engine_adapter.fetchall(
exp.select("name", "identifier", "content").from_(self.seeds_table).where(where)
exp.select("name", "identifier", "content")
.from_(self.seeds_table)
.where(where),
quote_identifiers=True,
)
}
if not seeds:
Expand Down