Fix!: Normalize dbt model cluster_by field#2305
Merged
Conversation
crericha
force-pushed
the
normalize-clustered-by-list
branch
from
a37043b to
5ffe299
Compare
izeigerman
approved these changes
Mar 19, 2024
Contributor
izeigerman
left a comment
izeigerman
left a comment
There was a problem hiding this comment.
Can we please add a test specific to dbt since this is where the issue occurred?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a gap in
clustered_bynormalization where we didn't normalize if passed in a list. This PR adds normalization for list types.Fixes #2293