Skip to content

chore: cleanup dialect variable reuse #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eakmanrq merged 1 commit into from
Mar 26, 2024
Merged

chore: cleanup dialect variable reuse #2350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sqlmesh/core/model/kind.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,8 +384,9 @@ def _time_data_type_validator(
values = values if isinstance(values, dict) else values.data
if isinstance(v, exp.Expression) and not isinstance(v, exp.DataType):
v = v.name
data_type = exp.DataType.build(v, dialect=values.get("dialect"))
data_type.meta["dialect"] = values.get("dialect")
dialect = values.get("dialect")
data_type = exp.DataType.build(v, dialect=dialect)
data_type.meta["dialect"] = dialect
return data_type

@property
Expand Down